I also had to bypass SDL_FreeSurface(screen) is it was causing a double free error on exit, but I'm not sure where the culprit lies (likely another call freeing the same pointer?). When I have some free time to test and verify everything's ok, I'll send the atexit patch as a PR to your repo, but if you think my change isn't good enough, let me know and I can take a look at the code again (or you could do it yourself, perhaps). I've only had time to check basic functionality (mostly to verify that bypassing the atexit calls prevents the segfault on exit). It's necessary to avoid the use of atexit for SDL_Quit() due to a conflict between SDL2 and the Mesa driver's usage of atexit see: Īdditionally, it's necessary to enable vsync for kmsdrm contexts due to a driver bug causing a drastic performance reduction when vsync is disabled. Without any changes to your source, the build is segfaulting on exit - but I know the cause. I've started work on updating the scriptmodule to use your fork, commit is here (not yet submitted as a PR): Is someone working on this, or is there someone who'd like a (neater) patch? What would be the preferred format? A git push to the HerbFargus git tree, a manual diff to it in the Retropie install script? but I'm trying to track down a segfault-at-exit but it doesn't affect gameplay at all and isn't visible when used from ES. It works and I've played four-player games with joypads, sound, fullscreen video etc. a handful of small source / Makefile changes to use SDL2 libraries / includes and the above wrappers, silencing a warning that turns into an error otherwise, and not bothering with the level editor, world editor, etc. ![]() a hardcoded resolution in the scaler code in the above file (but nothing stopping that being read at runtime from a file or command line if necessary) to stretch it to 1280x1024 (my screen size).the SDL2 library equivalents (SDL2_mixer, image, etc.) and sdl2-config.the existing smw retropie port scripts (with the -kms removed to make it appear/install on RPi4). ![]() ![]() I got SMW working fullscreen on RPi4 / SDL2, would anyone be interested in my coding up the patches or is someone else already working on that?
0 Comments
Leave a Reply. |
Details
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |